LBP1 Script Blocking Hook #16
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
HugeSpaceship/Patchwork!16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "script-blocking-hook"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR adds a code patch that will block scripts from loading over P2P in LBP1, patches for lbp2 and 3 will come later
It looks fine for the moment, I assume this still doesn't work outside of LBP1?
Edit: nvm i clearly can't read
@ -13,6 +13,7 @@#include "offsets.h"Should this be considered a major version change?
LittleBigPlanet 1
@ -13,6 +13,7 @@#include "offsets.h"I will do that separately from this PR, as a tagged release. In the future I'd like to avoid changing the release numbers from code, and I'm probably going to do some dumb automation for it in the pipeline.
ppc64 assembly, I am terrified yet impressed. From my somewhat limited knowledge of C and 5 seconds of analyzing g3 ppc and cell ppc64 instructions in other projects, this looks fine.
Were larger URLs colliding with other segments of memory, requiring that 32 byte cap?As far as I know this hasn't been an issue anyone has run into before, but we can't go over the size of the URL as it is defined by the game already as it would write out of the bounds of the array. That is unless we also change the size of the char array, which is more likely to be a C++ string object of some kind (possibly the custom MMString type) and would require even more hacking to change the URL size. This isn't really new though and since to my knowledge no server has ever had a URL long enough to surpass 32 characters, it's never really been a concern.
-# for the record i can't tell if this is satire
Yes, if you patch LBP to a larger URL size it breaks online connectivity, hence the limit.
Made a mistake, forgot how strings worked.